[PATCH] KMix

[Ralf Nolden]

On Samstag, 6. Dezember 2003 12:04, Aaron J. Seigo wrote:
> On Saturday 06 December 2003 03:10, Stephan Kulow wrote:
> > > 2) proper hiding of the main window when clicking on the systray icon
> > > in certain situations. the comment in the code even references
> > > "LeftButton", but in the code it was "MidButton". oops. i've had this
> > > one laying around on my hard disk for a long while and apparently
> > > completely forgot about it. =/
> >
> > I wondered myself why what used to work with left button now shows the
> > main window
>
> well... the patch as i posted it doesn't revert that part of the new
> behaviour, though i agree it should. as it stands, those without middle
> mouse buttons can't get to the main mixer window. i don't know how many
> people will try middle clicking on it, and it is a deviation from how it
> was in previous releases. i know that the slider-on-left-click was done
> based on user requests, and i haven't heard of any complaints about it....
>
> i also just noticed that the "don't keep showing the volume slider when you
> click a second time on the systray icon" logic doesn't work properly. i'll
> put together another patch that fixes this and restores the mouse button
> mappings to the way they were in 3.1...

Thank you :)
>
> one improvement that could be made in a future relase is adding a button to
> the volume slider that shows the main mixer window.

I would think this is feature overloading. This button isn't necessary as you 
can alway access the main window with the middle mouse button and with the 
rmb popup menu.

People are used to simple and non-confusing behavior :)

Ralf

-- 
We're not a company, we just produce better code at less costs.
--------------------------------------------------------------------
Ralf Nolden
nolden at kde.org

The K Desktop Environment       The KDevelop Project
http://www.kde.org              http://www.kdevelop.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031206/7eba84f8/attachment.sig>