PATCH: Better cross-domain cookie detection [BR 66090]

Waldo Bastian bastian at kde.org
Mon Dec 1 12:12:14 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon December 01 2003 01:53, Dawit A. wrote:
> I have reverted it back with the exception that we no longer need to assign
> it to a KURL object first.
>
> > And more general, it fails to check if req->m_docLoader->part() is null.
>
> Added the check for a NULL part. I assumed it could never happen, but it
> never hurts to check anyways.

Excellent. I would add .url() to req->m_docLoader->doc()->URL()

And sourceURL() seems a bit strange name. What about "toplevelURL()" ?

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SUSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/yzAeN4pvrENfboIRAoyNAJ9ceSJgbgSPi6dd3pKXSwJHaUudRgCgoqau
5hs9qJljC8NxirxjsD5e1Hw=
=6ldn
-----END PGP SIGNATURE-----




More information about the kde-core-devel mailing list