[PATCH] Replacing email selection dialog in kmail

Tobias Koenig tokoe at kde.org
Mon Dec 1 10:13:43 GMT 2003

On Sun, Nov 30, 2003 at 08:15:01PM -0500, Zack Rusin wrote:
> On Sunday 30 November 2003 19:48, Ingo Klöcker wrote:

> > Yes, it does work properly when resizing. I don't know what you mean
> > with "etc", so I can't comment on "etc".
> I don't exactly remember who requested them, but the reasoning iirc was 
> "sometimes i want to see full names and emails in one tree, and because 
> both of them scale by the same amount i'm often left with a huge window 
> with one completely unused tree and other barely fitting the 
> informations i wanted", hence the splitters.
Hmm, wouldn't a QGridLayout::setColStretch(0,10) be enough for this

> > Unless someone else actually properly implements the functionality
> > behind those buttons (see my other message) you should accept this as
> > an interim solution.
> Well, "this is rather crappy" is obviously my comment and it's there 
> because _this_ was the interim solution. Tobias was supposed to export 
> the addressee editing widget from kaddressbook, but i guess didn't have 
> enough time to do it.
It was not the lack of time but the structural changes that would have
been needed to factor out the dialog of KAddressBook. We were short
before feature freeze, so we (Cornelius and me) agreed to postpone it to
after 3.2.

> > Also the members of the distribution lists should still be listed
> > below the distribution list names to make it easy for the user to
> > check who's in the list.
> ack.
> Tobias, also one more comment : do not remove the initConnections 
> function. Why did you do it anyway?  I don't like when people do fifty 
> different things in constructors especially if the class is a part of a 
> library, because later if you want to add another constructor while 
> keeping bc you're forced to export most of it to a common 
> initialization method or duplicate 90% of the code.
Right, just moved it for debugging... will move it back before commit.

Can a government that shoots at reporters be democratic?
Separate politics from religion and economy!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031201/4ed47129/attachment.sig>

More information about the kde-core-devel mailing list