[PATCH] Replacing email selection dialog in kmail

Zack Rusin zack at kde.org
Mon Dec 1 01:15:01 GMT 2003

On Sunday 30 November 2003 19:48, Ingo Klöcker wrote:
> On Monday 01 December 2003 00:39, Aaron J. Seigo wrote:
> > On Sunday 30 November 2003 03:26, Tobias Koenig wrote:
> > > The splitter has gone
> >
> > and it works properly when resizing, etc? i'm recompiling
> > kdelibs/base atm so can't check myself... the proportions should
> > remain, with the center column not growing... sorry for not being
> > able to try it out right now myself
> Yes, it does work properly when resizing. I don't know what you mean
> with "etc", so I can't comment on "etc".

I don't exactly remember who requested them, but the reasoning iirc was 
"sometimes i want to see full names and emails in one tree, and because 
both of them scale by the same amount i'm often left with a huge window 
with one completely unused tree and other barely fitting the 
informations i wanted", hence the splitters.

> > > as well as the New, Edit and Remove buttons. Instead an 'Address
> > > Book...' button is added which allows you to start kaddressbook.
> >
> > see my email in reply to Ingo why this is a poor idea, IMHO.
> Unless someone else actually properly implements the functionality
> behind those buttons (see my other message) you should accept this as
> an interim solution.

Well, "this is rather crappy" is obviously my comment and it's there 
because _this_ was the interim solution. Tobias was supposed to export 
the addressee editing widget from kaddressbook, but i guess didn't have 
enough time to do it. So I don't know, I mean my view of that code is 
pretty obvious from looking at the comment. I like the functionality, I 
don't like the code - that's my opinion as a codemonkey (good looking 
one though).

> > > Furthermore you can move distribution to the 'Selected
> > > Addresses' listbox now.
> >
> > whee! yes, putting them in a group is good. the only thing i'd
> > change there is hiding that item when there are no distribution
> > lists. a quick check for (distLists.begin() == distLists.end())
> > should work ...
> Also the members of the distribution lists should still be listed
> below the distribution list names to make it easy for the user to
> check who's in the list.


Tobias, also one more comment : do not remove the initConnections 
function. Why did you do it anyway?  I don't like when people do fifty 
different things in constructors especially if the class is a part of a 
library, because later if you want to add another constructor while 
keeping bc you're forced to export most of it to a common 
initialization method or duplicate 90% of the code.


Stress is when you wake up screaming and you realize you haven't
fallen asleep yet. 

More information about the kde-core-devel mailing list