[PATCH] kdebase/kicker/toolbar: do not split window caption tooltips

John Firebaugh jfirebaugh at kde.org
Sun Aug 24 23:53:26 BST 2003


On Sunday 24 August 2003 02:20 pm, Stanislav Kljuhhin wrote:
> please review and consider applying.

> +        QToolTip::add( this, currentTooltip="<qt><nobr>" + QStyleSheet::
escape(name()) + "</nobr></qt>" );

Ugh. Please don't assign variables as a side effect.

Besides that, I think this will make unreasonably wide tooltips, and feels 
like a hack to me. Please consider improving Qt's line-break algorithm 
instead.

-John




More information about the kde-core-devel mailing list