Introducing and Devices Kicker Applet

[Aaron J. Seigo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 23 August 2003 09:51, Kévin Ottens wrote:
> Now, I wish to payback for all the years of fun and services all
> the KDE developers have given to us in general and to me in
> particular.

terrific =)

> For now you can download it here:
> http://ervin.tuxfamily.org/download/devicesapplet-20030822.tar.bz2
>
> I'm waiting for your comments and/or advices.

very nice! i think this is definitely quality enough to be in KDE...

my only thoughts are:

	o instead of calling it devicesapplet (which is how it appears in the Add -> 
Applets menu), call it just Devices.. we know it's an applet ;) , and it 
should be capitalized as its a name.

	o i wonder if left clicking should bring up the menu that is currently 
associated with the RMB, which an added "Open" entry? after using it, i'm 
wondering if "average" users will find the RMB menu with all its usefullness, 
or just click on the icons and often get the "not mounted" option?

	o the service menus integration is a great idea. =) the code dupe isn't 100% 
optimal, but no reason not to put it in CVS as it's only a few dozen lines 
and there's no other way around it right now. perhaps i'll factor out the 
servicemenu generation code from konq_popupmenu.cc for KDE 3.3 if this is in 
CVS....

but those aren't huge issues at all, IMHO... really great job =)) i'm 
forwarding this on to kde-core-devel where it will get read by more of the 
core developers. also, email sysadmin at office.kde.org for a CVS account so you 
can add and maintain this gem...

this also reminds me how the devices:// ioslave could use some work =) e.g. 
combining mounted/unmounted in the selection dialog... doing a better job of 
catching dupe entries such as a CD-ROM that is also a CD-Writer =)..

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/R8Sh1rcusafx20MRApc6AKCttdsOYoO+ibPW2a+DjJyjqEa2JwCaA77p
enGv+Mww/1D+9ERcY/wUvgw=
=5+/9
-----END PGP SIGNATURE-----
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<