KAutoConfigDialog

[Benjamin Meyer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 16 April 2003 5:29 am, Waldo Bastian wrote:
> On Wednesday 16 April 2003 10:30, Benjamin Meyer wrote:
> > >When the number of options in your dialog increase there
> > > comes a time that you want to actually order them, that will not happen
> > > if it means that you have to redesign much of the code in order to move
> > > from KAutoConfigDialog to some .ui file driven approach.
> > > The right approach IMHO is to use .ui files from the begin. That way
> > > the UI can be designed driven by UI concerns and not driven by
> > > limitations of the implementation.
> >
> > I am not sure I follow you on this.  The order of the dialog is
> > determined by the order of the widgets that are put in.  Also in the
> > example I gave (KTron) the three objects pass were just three ui
> > generated files will no actual developer written code.  Could you explain
> > a little more?
>
> Ah! I should have looked better indeed. I thought that the three widgets
> that you added were line-edits or so but they are basically a whole page
> themselves already. Maybe addWidget() should be named addPage() ?
> Other than that it looks very nice indeed.
>
> Can't the doneSetup() be done automatically? E.g. the caller would just
> call dialog->show() and KAutoConfigDialog would call
> KDialogBase::enableButton and KAutoConfig::retrieveSettings from a
> reimplemented showEvent or polish function. Not sure which one would be
> best.

Good point, I have renamed the function and removed doneSetup and implimented 
it into show().  Good enough to put into the libs?

- -Benjamin Meyer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE+nTsN1rZ3LTw38vIRApI/AJsHZawgMCko1kBnLqBrlurpNVgmAgCfewJ2
rvTnnQli9n4fotqCgXykatY=
=wSyU
-----END PGP SIGNATURE-----