kdelibs/kdeui

[Waldo Bastian]

On Monday 14 April 2003 15:35, you wrote:
> El Lunes, 14 de Abril de 2003 11:33, Waldo Bastian escribió:
> > On Monday 14 April 2003 01:28, Antonio Larrosa Jiménez wrote:
> > > Can somebody please backport this patch to the KDE_3_1_BRANCH ?
> >
> > No, it is effectively an API change. The show tip action works just fine
> > as long as you add it manually to the XML file of your application.
>
> ... which is not neccesary for any other KStdAction. What makes the tip
> action special ?

I agree with you that this behavior is stupid. The problem is that this stupid 
behavior has been released and that applications depend on it.

> > this action is added automatically in KDE 3.1.2 then applications
> > written against 3.1.2 (which are then unlikely to add this manually to
> > their own XML file) will have this menu-item missing when run against
> > 3.1.1
>
> Yes, but that was because of a bug in 3.1.1. According to your reasons, I
> understand that the patch should also be removed from HEAD, because then,
> kopete (for example) which tries to work with any 3.x kdelibs version will
> have problems (getting two tip actions in the help menu of HEAD if
> kopeteui.rc includes help_show_tip, and getting no tip action at all with
> kde 3.1.1 if they don't include it).

Ugh. With KMail in head I have now two tip menus as well indeed.

> As I understand it,(1) the tip KStdAction wasn't working in KDE 3.1.1, so
> it's ok to fix it for 3.1.2 and 3.2. Another option (2) is to think that
> it was working if you did a workaround, so the workaround should be kept
> in 3.1.2 (but the workaround will break in 3.2), and finally, the last
> option (3) is to keep the workaround for 3.x (x>=2) reverting my commits
> and forcing developers to include the tip action in their .rc files (in
> this case, the docs should reflect that the behaviour of
> KStdAction::tipOfDay is different than the other actions)
>
> Should I revert then and keep the workaround working ? or should it be
> fixed in the branch too? (I don't think we should break "working" code in
> 3.2, so I'm against the 2nd option).

I'm afraid we should do (3). Maybe someone on kde-core-devel has a better 
solution.

Cheers,
Waldo
-- 
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com