Simon Hausmann hausmann at kde.org
Fri Sep 27 17:53:12 BST 2002

On Fri, Sep 27, 2002 at 11:22:13AM +0200, Lukáš Tinkl wrote:
> Hi,
> anybody objects if I move klanguagebutton.{cpp,h} to kdelibs/kdeui?
> Currently it is duplicated in many places (only in kdebase in 4 applications):
> lukas at goblin:/usr/local/src/cvs/kdebase> find . -name klanguagebutton.h
> ./khelpcenter/klanguagebutton.h
> ./kcontrol/kdm/klanguagebutton.h
> ./kcontrol/locale/klanguagebutton.h
> ./kpersonalizer/klanguagebutton.h
> ..perhaps in other modules as well..
> Opinions?

Good idea IMHO. The API looks quite sane and the implementation as
well. With a d-pointer added and a delete m_tags; in the destructor
(or m_tags turned form a pointer into a real object right away) I
think it would fit in kdelibs.


More information about the kde-core-devel mailing list