Kasbar improvements

[Richard Moore]

----- Original Message -----
From: "Matthias Ettrich" <ettrich at trolltech.com>
To: <kde-core-devel at mail.kde.org>
Sent: Monday, September 02, 2002 10:11 AM
Subject: Re: Kasbar improvements


> On Sunday 01 September 2002 16:49, Benoit Walter wrote:
> > Hello,
> >
> > I've been using kasbar for a while and I really find it very useful, but
> > unfortunately there were some problems which made it a little annoying :
> >
> > 1. Sometimes an iconified app can't be raised when clicking on the
kasbar
> > icon (when all tasks are iconified and that one clicks several times on
a
> > kasbar icon). I resolved the problem in modifying the
> > KasTaskItem::mousePressEvent procedure (using activateRaiseOrIconify()
> > directly).
> >
> > 2. Kasbar should have a size of zero when no more windows are present
> > (especially important when kasbar is not in transparent mode). I removed
> > the condition with empty bar in the procedures
> > QSize KasBar::sizeHint( Orientation o,  QSize )
> > and void KasBar::updateLayout()
> > (there's no reason why the size of kasbar should not be reduced when
> > there's no task left...)
> >
> > The modifications are trivial, I can send a patch against the latest CVS
> > version if you want to, I just would like to have the opinion of the
kasbar
> > developpers... The first bug is very annoying and I think it should be
> > corrected before the final release of KDE 3.1 !
> >
> > Best regards,
> > Benoit Walter
> >
> > b.walter at free.fr
> > benoit.walter at esstin.uhp-nancy.fr
>
> All your modifications sound very reasonable. I'm not sure who maintains
> kasbar right now. If no one speaks up and you send me the patches, I'll
> review them and put them in.

I'm the maintainer, please mail me the patch and I'll apply it. The minimum
size thing is
because originally there were no handles on kicker extensions (in fact there
was no
API for extensions at all!).

Rich.

>
> Matthias
>