[PATCH] Style fix for kdesdk/kapptemplate/kpartapp

Waldo Bastian bastian at kde.org
Tue Sep 3 19:12:54 BST 2002


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 03 September 2002 02:03 am, Dominique Devriese wrote:
> Dominique Devriese <fritmebufstek at pandora.be> writes:
> >                            If the application  is  in its initial state 
> > and the user opens a new document by selecting either New  or Open in 
> > the File-menu, then the document is  loaded into  the   application,
> > replacing the empty default    document.     This causes    the
> > application to leave the initial state.
> >
> >                            If the application  is NOT  in the initial 
> > state and the  user opens a  new document  by selecting either  New or
> > Open in the  File-menu, then a new application is started in  which the
> > document  is loaded.
> >
> > The style guide doesn't seem to make the distinction between new and
> > open at all... ( you must be confused too :P )
> > So, my fix is wrong, but the current situation is too..
> > ( or am i missing something here.. )
> > I'll try to come up with a new patch...
>
> Hi, here's the new patch.  I think this implements the style guide
> correctly now...
> Any comments ?  Ok to commit ?

Looks good, can you pass "this" as parent to getOpenFileName() ?

Cheers,
Waldo
- -- 
bastian at kde.org  |   SuSE Labs KDE Developer  |  bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9dPumN4pvrENfboIRAk71AJ9KnlHmeyOz9KtvCpEoImOTU8pTmQCZATQr
4YmfBB3TycdBqR23dIYnJ8g=
=taRJ
-----END PGP SIGNATURE-----





More information about the kde-core-devel mailing list