[PATCH] Style fix for kdesdk/kapptemplate/kpartapp

[Jason Bainbridge]

I think the confusion is in the style guide by the following wording:

"If the application is in its initial state and 
the user opens a new document by selecting either 
New or Open in the File-menu..."

What it means is (well from what I understand atleast):

"If the application is in its initial state and 
the user creates a new document by selecting  
New in the File-menu or opens an existing document by selecting Open in the File-menu..."

Regards,
Jason

-----Original Message-----
From: Dominique Devriese <fritmebufstek at pandora.be>
To: kde-core-devel at mail.kde.org
Date: 03 Sep 2002 10:03:46 +0200
Subject: Re: [PATCH] Style fix for kdesdk/kapptemplate/kpartapp

Thomas Zander <zander at planescape.com> writes:

> On Tuesday 03 September 2002 09:28, Dominique Devriese wrote:
> > Hi,
> > since i don't seem to be getting any replies to this on kde-devel,
> > i'll try again here.
> > I have found what I believe to be a style guide bug in the
> > kapptemplate template for kpartapp.  The problem is with the file_open
> > action.  If I understand the Style Guide correctly, this should open a
> > new windows showing the document, instead of closing the old document,
> > and opening the new one instead in the same window.  I'm including an
> > patch for this.  I have tested the patch, and it works fine for me.
> > I appreciate any comments.
> > cheers
> > domi
> 
> File "new" does what you say, not file "open".
> I think you confused them.
> See:
> http://developer.kde.org/documentation/standards/kde/style/menus/file.html

Hm.. i just read the page, and here is the relevant part:

                           If the application  is  in its initial state  and 
                           the user opens a new document by selecting either 
                           New  or Open in  the File-menu, then the document 
                           is  loaded into  the   application, replacing the 
                           empty default    document.     This causes    the 
                           application to leave the initial state.           
                                                                             
                           If the application  is NOT  in the initial  state 
                           and the  user opens a  new document  by selecting 
                           either  New or Open in the  File-menu, then a new 
                           application is started in  which the document  is 
                           loaded.

The style guide doesn't seem to make the distinction between new and
open at all... ( you must be confused too :P )
So, my fix is wrong, but the current situation is too..
( or am i missing something here.. )
I'll try to come up with a new patch...
cheers
domi

-- 
I'm reporting for duty as a modern person.  I want to d the Latin Hustle now!