Fwd: [kde-solaris] Patches for kde-3.1-beta2 on Solaris 2.8/Forte C++ 6.x

Alex Zepeda zipzippy at sonic.net
Sat Oct 12 21:16:52 BST 2002

On Sat, Oct 12, 2002 at 05:48:19PM +0200, Eva Brucherseifer wrote:

> Maybe these patches can be considered for inclusion before 3.1? I only had a
> quick look and had the impression, that they might not work for other
> platforms. But you guys are more involved with the code, maybe you can make
> something out of it.
> You'll find the complete message with all attachments on 
> http://lists.kde.org/?l=kde-solaris&m=103443614226856&w=2

Here's my first thoughts on this.. I'm having some trouble getting kdelibs
to autofoo correctly so I can't even begin to build it *SIGH*.... but I
did glance thru the patches.

ksysguard/ksysguardd/Solaris/Makefile.am looks okay to me, I'll commit 
that if there are no objectsions.

kdialog/kdialog.cpp: no real objection here either, should kdebug be used 
here or is this something that intentionally writes to stdout?

konsole/konsole/konsole.cpp, konsole/konsole/TEWidget.h: looks okay to me

konsole/konsole/keytrans.cpp: if you're going to use casts could you
please use "C++ style" / "template" casts?

kdebase-3.0.8/konsole/konsole/konsole_grantpty.c: looks okay

libkonq/konq_popupmenu.cc, khelpcenter/navigator.cpp: okay (still.. pretty
casts would be nice)

kioslave/nfs/mount_xdr.c: okay.. on a side note I wonder if register is 
really of any use here?

kcontrol/kio/kproxydlg.cpp: oy..  will commit if no objections.

kcontrol/info/memory_solaris.cpp: sane enough willing to commit

kcontrol/kfontinst/kfontinst/Ttf.h: okay

kcontrol/kfontinst/kfontinst/FontEngine.cpp: is this really necesary, 
maybe my eyes have gone out.. but are the casts necesary for strchr?

kicker/share/menuinfo.cpp: again with the type of cast

kicker/applets/clock/clock.cpp: unsure if time.h is needed elsewhere, 
perhaps this should be wrapped around an ifdef HAVE_TIME_H

kpager/main.cpp: no brainer, will commit.

As far as the libtool changes.. have they been run by the libtool
developers yet?

You don't happen to have a testbox with solaris that I can play around on
w/ KDE do you? :)

- alex

More information about the kde-core-devel mailing list