patches for knode

[Christian Gebauer]

Hi, 

On Thursday 10 October 2002 01:02, CP Hennessy wrote:
> Hi,
> 	Attached are a few patches for some annoying problems in knode.
>
> kncleanup.cpp.patch & knarticlefilter.cpp.patch avoids infinite loops
> and fixes bug:34383 ( and all of it's various duplicates )
> I'm sure that there may be a better way to avoid this but this works.
>
> knarticlewidget.cpp.patch allows "www" in a newsgroup name (bug:47179)
> and correct behaviour for timeouts so that read article counts are
> correct (bug:38647 )
>
> There are no feature changes, and no string changes.

Thanks for your work, I am sorry that I don't help you...
The patches are fine, but I don't like the fix for #47179, my suggestion
would be the following patch, unless you want to change the behaviour of
::toHtmlString because of other problems.

--- knarticlewidget.cpp 2002/09/19 20:53:37     1.139
+++ knarticlewidget.cpp 2002/10/10 13:25:23
@@ -1024,6 +1024,8 @@ void KNArticleWidget::createHtmlPage()
       } else if(hb->is("Date")) {
         KMime::Headers::Date *date=static_cast<KMime::Headers::Date*>(hb);
         
headerHtml+=toHtmlString(KGlobal::locale()->formatDateTime(date->qdt(), 
false, true));
+      } else if(hb->is("Groups")) {
+        headerHtml+=toHtmlString(hb->asUnicodeString(),false);
       }
       else
         headerHtml+=toHtmlString(hb->asUnicodeString(),true);

Greetings
Christian
-- 
>><< Christian Gebauer >><< gebauer at gmx.com >><< ICQ 14916141 >><<