PATCH: fix #47757

[Lubos Lunak]

On Wednesday 09 October 2002 21:37, Ellis Whitehead wrote:
> On Wednesday 09 October 2002 19:45, Lubos Lunak wrote:
> >  Hello,
> >
> >  please review the attached patch for bug #47757. It provides both
> > suggested solutions, because the first one simply makes sense (KDE
> > Alt+Tab style isn't really that funny when it switches only between two
> > windows), and the second one is a bug introduced by a developer who
> > wished to stay anonymous :).
>
> I think that there may be a problem with the following part of your patch:
>
>          if ( areModKeysDepressed( cutWalkThroughWindowsReverse ) ) {
>              if ( startKDEWalkThroughWindows() )
>                  KDEWalkThroughWindows( false );
>          } else {
> -            KDEOneStepThroughWindows( false );
> +            CDEWalkThroughWindows( false );
>          }
>
> If you want to test for a non-modified key, you can't use
> areModKeysDepressed().  That function is meant to check for cases where the
> user presses a task-switch key and releases it before Workspace starts
> running.  If you want to test whether the shortcut has no modifiers, then
> it needs to be done differently.  The code for doing that is ugly.  For
> example, the following might work:
> 	if( cutWalkThroughWindows.seq(0).key(0).modFlags() == 0 )
> It checks the modifier flags on the first key of the primary key sequence
> of the WaltThroughWindows shortcut.

 But the patch doesn't change anything about that, that code actually is yours 
(kdebase/workspace.cpp r1.265), and I honestly don't understand from your 
descriptions what's wrong with it.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/