PATCH: fix #47757

Ellis Whitehead ellis at
Wed Oct 9 20:37:29 BST 2002

On Wednesday 09 October 2002 19:45, Lubos Lunak wrote:
>  Hello,
>  please review the attached patch for bug #47757. It provides both
> suggested solutions, because the first one simply makes sense (KDE Alt+Tab
> style isn't really that funny when it switches only between two windows),
> and the second one is a bug introduced by a developer who wished to stay
> anonymous :).

I think that there may be a problem with the following part of your patch:

         if ( areModKeysDepressed( cutWalkThroughWindowsReverse ) ) {
             if ( startKDEWalkThroughWindows() )
                 KDEWalkThroughWindows( false );
         } else {
-            KDEOneStepThroughWindows( false );
+            CDEWalkThroughWindows( false );

If you want to test for a non-modified key, you can't use 
areModKeysDepressed().  That function is meant to check for cases where the 
user presses a task-switch key and releases it before Workspace starts 
running.  If you want to test whether the shortcut has no modifiers, then it 
needs to be done differently.  The code for doing that is ugly.  For example, 
the following might work:
	if( cutWalkThroughWindows.seq(0).key(0).modFlags() == 0 )
It checks the modifier flags on the first key of the primary key sequence of 
the WaltThroughWindows shortcut.


More information about the kde-core-devel mailing list