[PATCH] KJanusWidget compatibility with QTabWidget

Simon Hausmann hausmann at kde.org
Fri Nov 22 23:02:05 GMT 2002


On Fri, Nov 22, 2002 at 02:00:13PM -0500, Ravikiran Rajagopal wrote:
> > Your patch looks good IMHO, except for one thing: I think removePage
> > should take a bare QWidget pointer, not a const one.
> My preference too. Please see attached patch. (The reason for originally using 
> a const pointer was that QObject::sender() returns a const pointer, and I 
> preferred to make explicit the points at which constness needed to be casted 
> away.)

Looks good to me. BTW, I think the const_cast can be avoided by
connecting to the destroyed( QObject * ) signal of QObject, instead
of the destroyed() one and using sender() then. But that's a
separate issue.

Simon




More information about the kde-core-devel mailing list