[PATCH] KJanusWidget compatibility with QTabWidget

Ravikiran Rajagopal ravi at ee.eng.ohio-state.edu
Fri Nov 22 19:00:13 GMT 2002


> Your patch looks good IMHO, except for one thing: I think removePage
> should take a bare QWidget pointer, not a const one.
My preference too. Please see attached patch. (The reason for originally using 
a const pointer was that QObject::sender() returns a const pointer, and I 
preferred to make explicit the points at which constness needed to be casted 
away.)

> One the subject of that crash you experienced, with QTabWidget: Do
> you happen to have a testcase?
I do not have a problem with QTabWidget. The reason is that 
QTabWidget::removePage() calls QWidgetStack::removeWidget(). Personally, I 
still believe that the problem is actually in QWidgetStack (Qt bug report 
10734) which is manifested only in KJanusWidget.

Thanks for your comments,
Ravi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kjanuswidget2.diff
Type: text/x-diff
Size: 3407 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20021122/2e3aaf2b/attachment.diff>


More information about the kde-core-devel mailing list