Fixing #47517

David Faure david at mandrakesoft.com
Wed Nov 20 09:20:18 GMT 2002


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 20 November 2002 01:43, Michael Brade wrote:
> Robert is right, the problem was that m_dictSubDirs contained references to 
> already deleted items which caused the crash. (For me it crashed in 
> saveState, which also accesses the items in m_dictSubDirs). KDirLister 
> emitted deleteItem not for all subdirs (which is ok, the view should 
> recursively remove the items itself) and thus the treeview didn't remove the 
> subdir from m_dictSubDirs. The solution is to make 
> KonqTreeViewWidget::removeSubDir() recursive.

Looks good to me.

> BTW, we need to "delete" every single item in deleted directories with 
> m_pBrowserView->deleteItem() to remove it from the statusbar counts.

I see. Well, shouldn't be a problem afaics.

> However, my patch seems to miss a case as the statusbar is still wrong for the 
> treeview...

This reminds me that some people see terabytes in the statusbar after deleting
a file (uint wrapping :).... next time I'll ask in which view mode this happens...

> Please review, test and give me an ok to apply :-)

Done, skipping the test part :)

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE921PT72KcVAmwbhARAioeAJ9GoA9olEsXzcPDmdwyyehAUf1pBgCfSwq2
9BydyxjHA+/nxmAo0qrld1U=
=XESy
-----END PGP SIGNATURE-----





More information about the kde-core-devel mailing list