[patch] Konq dialogs and "always on top"

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 19 November 2002 16:56, Scott Wheeler wrote:
> Currently most of Konq's dialogs are created "parentless".  This causes real 
> problems when you set Konq to be "always on top".
> 
> Test case:  Start up Konq (in file browsing mode), maximize it and set it to 
> "always on top".  RMB Menu -> Create New -> Directory...
> 
> You can't proceed until you edit something; you can't even return the focus to 
> the window that is taking up the whole screen.  You have to minimize it and 
> then handle the dialog, then proceed.
> 
> This patch (attached) makes as many of the Konq dialogs as I could find have 
> the KonqMainWindow as their parent.

Looks good. Never thought about this.

(The one case where you don't want a parent to be set is for dialogs that 
pop up asynchronously, like the old "host not found" dialog - in such a case,
it can be annoying, since it made the current desktop switch to the konq
window showing the msg box. However this doesn't happen anymore, now
that we show such errors inline in khtml using error://)

All those that you changed are "manually" activated AFAICS, so it looks ok.
Only d->m_over is a bit confusing, I would have called it d->m_parentWidget ;)

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE92pWR72KcVAmwbhARAqBEAJ49tBmr+y9Wcv7igRe4nLkMxJYqzwCfQuLD
a/xV96+j33eV/JF/Nby9dNY=
=yksr
-----END PGP SIGNATURE-----