[PATCH] kdelibs/kdeui/kpassivepopup.h

[Lubos Lunak]

On Friday 15 November 2002 13:35, David Faure wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Friday 15 November 2002 13:15, Carsten Pfeiffer wrote:
> > On Friday 15 November 2002 12:15, Simon Hausmann wrote:
> > > On Fri, Nov 15, 2002 at 11:39:51AM +0200, Andras Mantia wrote:
> > > > Minor patch for a compilation problem. Should I commit?
> > >
> > > Looks good.
> > >
> > > Simon (surprised noone noticed this before)
> >
> > *surprised why it builds just fine for me without the patch*
>
> Because kpassivepopup.cpp includes kpassivepopup.h _after_ the Qt and KDE
> includes. In libraries, I would rather recommend that the .cpp includes its
> own .h first, to ensure that the header file is "standalone" (i.e. useable
> by apps).

 I second that (I do that in all my code, even if it's app code).

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/