[PATCH] kdelibs/kdeui/kpassivepopup.h

David Faure david at mandrakesoft.com
Fri Nov 15 12:35:40 GMT 2002


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 15 November 2002 13:15, Carsten Pfeiffer wrote:
> On Friday 15 November 2002 12:15, Simon Hausmann wrote:
> > On Fri, Nov 15, 2002 at 11:39:51AM +0200, Andras Mantia wrote:
> > > Minor patch for a compilation problem. Should I commit?
> >
> > Looks good.
> >
> > Simon (surprised noone noticed this before)
> 
> *surprised why it builds just fine for me without the patch*

Because kpassivepopup.cpp includes kpassivepopup.h _after_ the Qt and KDE includes.
In libraries, I would rather recommend that the .cpp includes its own .h first,
to ensure that the header file is "standalone" (i.e. useable by apps).

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD4DBQE91Ood72KcVAmwbhARAl25AJdl+ecHC+VYllBIj0U7bTYGhU6OAJ9Y41c4
EtlJdochdY8/b3s9Cd8VGg==
=mkk0
-----END PGP SIGNATURE-----





More information about the kde-core-devel mailing list