[Issue N9282] Re: KMail folder changing bug (Was: Re: KDE 3.1: one week delay)

[Roger Larsson]

On Monday 11 November 2002 18.51, David Faure wrote:
> On Monday 11 November 2002 17:04, Roger Larsson wrote:
> >
> > Where can I find that patch? I am more than willing to try it.
> 
> Well my patch is simply:
> --- qlistview.cpp       2002/10/30 10:59:36     1.48
> +++ qlistview.cpp       2002/11/11 17:46:18
> @@ -4454,8 +4454,6 @@ void QListView::contentsMouseMoveEvent(
>             delete d->scrollTimer;
>             d->scrollTimer = 0;
>         }
> -       // call this to select an item
> -       doAutoScroll();
>      }
>  }
> 

Good news - it fixes the problem.

> However I guess there's a reason for that call (although the comment makes
> no sense to me), so maybe this patch breaks something - I'd be curious to
> find out why, though.

Bad news - well maybe?

Before you could select a directory and then change your mind, move to another 
folder, without releasing the button. This is not possible with the patch.

But I have no idea where this would be a nice to have / a bug not to have.

> 
> Hmm. I think doAutoScroll() using QCursor::pos() is the bug, (or the fact 
that
> doAutoScroll() is called from contentsMouseMoveEvent in the first place),
> no matter what the application does.
> 

The change that gets the pos from the current mouse position went in with
revision 1.48 of qlistview.cpp
But the difference from before is minimal. Before it used the latest processed
mouse position, that was set to the events pos in 1.47. Quite good actually.
But earlier revisions than that used the current mouse position.

It should use the latest detected mouse position with left mouse button still 
down IMHO. Using the latest processed position might be quite good
actually... - I will test that.

I guess our next assignment is to reproduce this with the Qt example that
enters the code in question...

/RogerL

-- 
Roger Larsson
Skellefteå
Sweden