kpanelextension

[Aaron J. Seigo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi.

doing some further work in simplifying and standardizing kicker and its 
configuration, i've removed the extensions panel from the kcm and made the 
extensions and the main panel use identical settings for things like hiding 
and orientation.

however, in doing so i ran into a snag w/regard to KPanelExtension. to be able 
to propagate the size changes to the extensions from outside the extension 
itself, i needed to add a protected virtual method to KPanelExtension due to 
the way it is designed.

it handled position and orientation, but not size (!) ... very strange.

obviously, this breaks BC with anything using KPanelExtension. according to 
LXR only kicker and kwintv3 use it. kwintv3 is still in nonbeta, so should be 
a non issue. the real question is whether or not it is ok to break BC on this 
one class which is used currently only by kicker (which makes me wonder why 
it was put in kdeui in the first place?)

without the change, i don't know if i'll be able to reliably have the 
extensions show size changes on the fly. the other alternative is to attempt 
to get a rather ugly little hack that i tried to work (though it seems there 
are easy ways around it, so it wouldn't be a great solution) or to leave the 
extensions as they are (which is broken IMHO). in other words: w/out this 
change i don't think the extensions can be configured from the kcm properly.

attached is the patch again KPanelExtension. thoughts? ideas? magic wand 
waving that will make this unecessary?

i've looked at the virtual_hook option and boy is it ever ugly. i'd like to 
avoid using that if at all possible.

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE87S+w1rcusafx20MRAvDGAJ9nYfOR653HoYgwezpz1CR5TKWMXACgsTpS
GG/RVoBJCewdrwgXA0Phbfk=
=t8iN
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kpanelextension.diff
Type: text/x-diff
Size: 3648 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20020523/c11535c2/attachment.diff>