kdelibs/kdeui

[Simon Hausmann]

On Sat, Jun 22, 2002 at 02:55:37PM +0200, Matthias Kretz wrote:
> Added Files:
>          kpreferencesdialog.cpp kpreferencesdialog.h
>          kpreferencesmodule.cpp kpreferencesmodule.h
> Log Message:
> no objections or comments, so here it is: A generic Preferences Dialog.
> Every page is created as a module that automatically adds itself to the
> dialog.
> Some of the docu is still TODO.
 
Interesting idea. Reminds me of kcmodule somehow ;)

Just one minor comment: I think it's a bad idea to use the singleton
pattern with KPreferencesDialog. For example imagine kword and
kspread both using KPreferencesDialog. Now imagine a kword document
with an embeddesd spreadsheet. You activate the spreadsheet,
kspread's GUI appears, you select 'Configure KSpread' . Trouble
ahead :)

Simon