[PATCH] KMainWindow::applyMainWindowSettings & SaveMainWindowSettings

[David Faure]

On Fri, 7 Jun 2002, Waldo Bastian wrote:

> On Friday 07 June 2002 02:42 pm, Nadeem Hasan wrote:
> > Hi,
> >
> > If the group name is not passed to the above two methods, the group that
> > used to read/write settings is completely random and results in the
> > settings not getting restored properly. The attached patch defaults the
> > group to "MainWindowSettings" to make the behaviour predictable.
>
> The behaviour is already predictable. If no group is specified it uses the
> current group. Changing that behaviour would break backwards compatibility.

Yes. See savePropertiesInternal(). That's where it needs to just use the
current group.
This patch would break session management.

> > BTW, why is the "group" parameter documented as "For internal use only"?
>
> I have no idea. I suggest to update the documentation to include that the
> settings are saved to "group" and that if "group" is empty the current group
> is used.

I agree. The documentation is indeed outdated, most programs have to
actually pass a meaningful group name here. Thanks for noticing this
issue.

David.