[PATCH] Adding accels on KStdAction::firstPage() & lastPage()

Thomas Zander zander at planescape.com
Mon Jun 3 22:36:51 BST 2002


I don't think it is a good idea to provide defaults like that. We allready have
almost no keys left..
The good thing about good defaults is that you provide the things needed and
not much more. Otherwise the defaults get in your way when you are personally
configuring stuff.


On Mon, Jun 03, 2002 at 05:07:59PM -0400, Nadeem Hasan wrote:
> Hi,
> 
> The patch adds Ctrl-Home and Ctrl-End accels to firstPage() and lastPage().
> 
> Ok to commit?
> 
> Cheers,
> -- 
> Nadeem Hasan
> nhasan at nadmm.com
> http://www.nadmm.com/
> 
> 
> Index: kstdaction.cpp
> ===================================================================
> RCS file: /home/kde/kdelibs/kdeui/kstdaction.cpp,v
> retrieving revision 1.69
> diff -u -r1.69 kstdaction.cpp
> --- kstdaction.cpp      2002/06/02 18:50:05     1.69
> +++ kstdaction.cpp      2002/06/03 21:06:04
> @@ -87,8 +87,8 @@
>         { Goto,          KStdAccel::AccelNone, "go_goto", I18N_NOOP("&Go To..."), 0, 0 },
>         { GotoPage,      KStdAccel::AccelNone, "go_goto_page", I18N_NOOP("&Go to Page..."), 0, "goto" },
>         { GotoLine,      KStdAccel::GotoLine, "go_goto_line", I18N_NOOP("&Go to Line..."), 0, 0 },
> -       { FirstPage,     KStdAccel::AccelNone, "go_first", I18N_NOOP("&First Page"), 0, "top" },
> -       { LastPage,      KStdAccel::AccelNone, "go_last", I18N_NOOP("&Last Page"), 0, "bottom" },
> +       { FirstPage,     KStdAccel::Home, "go_first", I18N_NOOP("&First Page"), 0, "top" },
> +       { LastPage,      KStdAccel::End, "go_last", I18N_NOOP("&Last Page"), 0, "bottom" },
> 
>         { AddBookmark,   KStdAccel::AddBookmark, "bookmark_add", I18N_NOOP("&Add Bookmark"), 0, "bookmark_add" },
>         { EditBookmarks, KStdAccel::AccelNone, "bookmark_edit", I18N_NOOP("&Edit Bookmarks"), 0, "bookmark" },
> 

-- 
Thomas Zander                                           zander at planescape.com
                                                 We are what we pretend to be
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20020603/0e3c4122/attachment.sig>


More information about the kde-core-devel mailing list