Can't add "increase/decrease font sizes" icons to location toolbar

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 24 July 2002 05:13, John Firebaugh wrote:
> The problem is that Increase/Decrease Font Size are KHTMLPart actions. 
> KHTMLPart has only a main toolbar entry in its ui file. In KEditToolbar, you 
> can add any part's actions to any toolbar. Then, the gui entries might be 
> written out to the wrong local ui file (konquerorui.rc instead of 
> khtml_browser.rc in this case).

Ouch.

> I can think of several ways to fix this.
> 0) Disallow inserting part actions in shell toolbars via KEditToolbar.
Maybe the only possible short term fix... not nice though.

> 1) Add an empty location toolbar node to khtmlpart.ui.
Doesn't fix the general case.

> 2) Have KEditToolbar display an artificial "Location Toolbar <khtmlpart>" 
> entry in the dropdown.
It still requires the user to pick up the right item. This goes the wrong way.
If it only works when saving in khtmlpart, then we simply want to show
"Location Toolbar" and let the destination xml file depend on the action
to be saved. That sounds like what you called 3).

> 3) Implement proper merging of toolbar actions in KEditToolbar. I'd really 
> like to see this happen, but it would probably be quite difficult to get 
> right.

It sounds like the correct fix though. I defended "A <b>" by saying
"otherwise we don't know in which XMLGUI file to add the action",
but you're saying: we DO know which file to use, it's the one used by
the XMLGUIClient that provides this action.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Back from holidays - 1750 mails
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9QAIg72KcVAmwbhARAlURAKCjSe36kh7kvQ6E3yhs6MMpkxdGCACfV1jm
3wv78LFkGlRkU7CyTql0Xs4=
=8F97
-----END PGP SIGNATURE-----