Viewport fault in netwm.cpp?

[Bradley T Hughes]

On Thursday 11 July 2002 12:54, David Boddie wrote:
> On Thursday 11 Jul 2002 11:50 am, Bradley T Hughes wrote:
> > On Thursday 11 July 2002 12:34, David Boddie wrote:
> > > I'm been looking at the viewport support in kdecore/netwm.cpp and
> > > found that the wrong parameters appear to be passed to the virtual
> > > method, changeDesktopViewport.
> > >
> > > This patch changes some array references so that the viewport origin
> > > is passed correctly.
> >
> > The message passed to the event function is invalid.  From
> > http://www.freedesktop.org/standards/wm-spec/x105.html:
>
> [...]
>
> > The patch you attached is incorrect, and the originator of the
> > viewport message needs to be fixed instead.
>
> Thanks for the quick response!

Not a problem...

> I think I see what's happened. Presumably, the message constructed is
> incorrect in that it mistakenly includes the desktop number at line 809:
>
> 802:        XEvent e;
> 803:
> 804:        e.xclient.type = ClientMessage;
> 805:        e.xclient.message_type = net_desktop_viewport;
> 806:        e.xclient.display = p->display;
> 807:        e.xclient.window = p->root;
> 808:        e.xclient.format = 32;
> 809:        e.xclient.data.l[0] = desktop - 1;
> 810:        e.xclient.data.l[1] = viewport.x;
> 811:        e.xclient.data.l[2] = viewport.y;
> 812:        e.xclient.data.l[3] = 0l;
> 813:        e.xclient.data.l[4] = 0l;
> 814:
> 815:        XSendEvent(p->display, p->root, False, netwm_sendevent_mask,
> &e);
>
> Is this the correct interpretation?

Yes, this is correct.  The message only changes the viewport for the 
current desktop, so this event is incorrect and needs to be fixed.

> > > On a related subject, can someone explain why there isn't there a
> > > signal in the KWinModule class for changes to the viewport?
>
> Anyone?
>
> David
>
> ________________________________________________________________________
> This email has been scanned for all viruses by the MessageLabs SkyScan
> service. For more information on a proactive anti-virus service working
> around the clock, around the globe, visit http://www.messagelabs.com
> ________________________________________________________________________

-- 
Bradley T. Hughes - bhughes at trolltech.com
Trolltech AS - Waldemar Thranes gt. 98 N-0175 Oslo, Norway