[PATCH] subdirs target dep in admin/Makefile.common

Oswald Buddenhagen ossi at kde.org
Mon Dec 9 14:55:05 GMT 2002


this tiny patch seems to rather controversial: micha and coolo insist
that it is wrong. i claim the opposite, of course.

it does two things:
- it adds a dependency of "subdirs" on "Makefile.am.in" (if the latter
  exists). this is required to make a simple "make" act upon changes of
  the compilation order defined with the relatively new 
  COMPILE_(BEFORE|AFTER)_ macros in Makefile.am.in.
  m&c claim that i'm fixing the wrong thing, but i've got another theory
  (they didn't bother to comment on this, so it remained a theory up to
  now): unsermake creates slightly different Makefiles (with broken
  dependencies), so my patch doesn't have any effect for them. hmm ...
- it removes the explicit dependency of configure.in on subdirs, as
  configure.files depends on subdirs and configure.in depends on
  configure.files. this _does_ work (prove the opposite, micha ;).


Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
Chaos, panic, and disorder - my work here is done.
-------------- next part --------------
Index: Makefile.common
RCS file: /home/kde/kde-common/admin/Makefile.common,v
retrieving revision 1.155
diff -u -r1.155 Makefile.common
--- Makefile.common	2002/10/11 07:40:54	1.155
+++ Makefile.common	2002/11/05 17:03:26
@@ -26,8 +26,9 @@
 	else MAKE=$(MAKE) $(SHELL) $$admindir/cvs.sh $@ ;\
-configure.in: configure.files $(shell test -f configure.files && cat configure.files) subdirs
+configure.in: configure.files $(shell test -f configure.files && cat configure.files)
 configure.files: subdirs
+subdirs: $(shell test -f Makefile.am.in && echo Makefile.am.in)

More information about the kde-core-devel mailing list