ftp copying progress dialog bug

[Ralf Nolden]

On Monday 29 April 2002 10:48, David Faure wrote:

> It shows the number of files *already* copied. 
Aaaaaaha !!! :))  I thought it displays the information on which file the 
progress is on copying (i.e. file #1,2,3...)

So when it comes to 4, the
> dialog closes, you can't see 4. No bug. Unless everyone agrees to do a +1
> in this field if it looks better for the user. So s/no bug/very easy fix/
> maybe ;)
I would suggest that as it is more intuitive I think (see what I thought on 
what it's doing, never thought it was a feature :))

>
> Please test.
> Index: job.cpp
Will do that. But I think that's pretty safe to add, isn't it ? :)

> > - the progressbar only works for the first file and stays at 100% for all
> > other files
>
> That looks like a bug. I don't remember seeing that though (I mean, since I
> rewrote CopyJob after KDE-2.2, to do this correctly).
>
> Is m_totalSize += ... triggered, in job.cpp:1881 ?
> What's the debug output from CopyJob::slotProcessedSize ? (you need
> to uncomment it) - uncomment also line 2748.
I can't do that right away because I need to get finished compiling, ironing 
and packing to leave tomorrow morning, sorry. Couldn't someone on IRC test 
this and has some spare time ?

Ralf
-- 
We're not a company, we just produce better code at less costs.
--------------------------------------------------------------------
Ralf Nolden
nolden at kde.org

The K Desktop Environment       The KDevelop Project
http://www.kde.org              http://www.kdevelop.org