ftp copying progress dialog bug

[David Faure]

On Monday 29 April 2002 10:35, Ralf Nolden wrote:
> Hi,
> 
> I just noticed just another time that when copying multiple files by ftp in 
> konqueror the progressdialog does:
> 
> - count the sum correct, but starts counting the download with file # 0 - so 
> for 4 files, it just counts up to 3

It shows the number of files *already* copied. So when it comes to 4, the dialog 
closes, you can't see 4. No bug. Unless everyone agrees to do a +1 in this field
if it looks better for the user. So s/no bug/very easy fix/ maybe ;)

Please test.
Index: job.cpp
===================================================================
RCS file: /home/kde/kdelibs/kio/kio/job.cpp,v
retrieving revision 1.304
diff -u -p -r1.304 job.cpp
--- job.cpp     2002/04/18 01:32:02     1.304
+++ job.cpp     2002/04/29 08:48:39
@@ -2220,6 +2220,7 @@ void CopyJob::createNextDir()
     else // we have finished creating dirs
     {
         state = STATE_COPYING_FILES;
+        m_processedFiles++; // Ralf wants it to start a 1, not 0
         copyNextFile();
     }
 }

> - the progressbar only works for the first file and stays at 100% for all 
> other files

That looks like a bug. I don't remember seeing that though (I mean, since I
rewrote CopyJob after KDE-2.2, to do this correctly).

Is m_totalSize += ... triggered, in job.cpp:1881 ?
What's the debug output from CopyJob::slotProcessedSize ? (you need
to uncomment it) - uncomment also line 2748.

-- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KDE, Making The Future of Computing Available Today