[PATCH] independence from gmake

[Michael Matz]

Hi,

On Wed, 24 Apr 2002, Adriaan de Groot wrote:

> /me removes the egg from his face before it hardens from being steamed

;-)

> I was trying again, but you've gone and committed my hacks along with
> some improvements of your own.

We were eager to try it with pmake ;)

> I'm a little ticked that this was committed "before its time", since it still
> doesn't work with BSD make.

Well, coolo told me, he build everything with NetBSD's make, so something
indeed does work.  I aggree it was before time, but for stable there is
3_0_BRANCH ;)

> Actually, it even breaks make -f Makefile.cvs in kdegames (at least
> with BSD make) (probably in all modules). I'm working on a fix. The
> exit code for cvs.sh is incorrect in some cases when configure_files
> is called.

This was already fixed yesterday evening.

> am_edit needs some patching as well.

Yep, something I forgot.  I looked at it and most of it seems safe.  Just
some questions: did you try srcdir!=buildir and srcdir==builddir?  The
addition of target x for each target $(srcdir)/x has the potential to
change something in that respect.

The part which adds the IDL files (i.e. _skel.cpp and _stub.h) looks
wrong.  First: you add both these files at once to $othermox (I believe
you want to collect there all generated files, or?), whereas each
iteration of that loop only creates one file (and possibly not both are
created at all).  This is something I'm not entirely sure about in the
moment. But second: You add _skel.cpp, whereas the created file is
called _skel.$cxxsuffix.  And why don't you add e.g. the _signals.h files?

Btw. you don't need to add all these "I broke this" equivalents
everywhere.  Mortification doesn't give more karma ;)  We can see changes
in the diff.

> Like I've said before, BSD make is less clever about canonicalizing
> target names than gmake is, so we need some extra targets without ".",
> since dependency names are usually written as "target", not
> "./target". The patch also adds a convenience target "all-mocs" that
> builds all the mocs in a directory. Shouldn't we have a .PHONY target
> listing all our fake targets, anyway?

Probably we should, yes.


Ciao,
Michael.