[PATCH] independence from gmake

[Adriaan de Groot]

On Friday 19 April 2002 15:43, Michael Matz wrote:
> On Fri, 19 Apr 2002, Adriaan de Groot wrote:
> > A first step in the make-agnostization and cleanup of the build system
> > can be retrieved from
> >
> > 	http://www.cs.kun.nl/~adridg/kde/bsd-make.html
> Well, even reading the first lines I notice such things, as:
>   if test "x$$AUTOCONF_VERSION" = "xAutoconf version 2.13"; then
> or
>   rm -f admin/$$file
>
> This won't work of course, $$ being pid in sh.

/me removes the egg from his face before it hardens from being steamed

> I didn't bother to read the rest yet.  Try again ;)

I was trying again, but you've gone and committed my hacks along with some 
improvements of your own. This seems to solve the $$ problems, \;, and splits 
cvs-clean out into its own little perl script. All fine.

I'm a little ticked that this was committed "before its time", since it still 
doesn't work with BSD make. Actually, it even breaks make -f Makefile.cvs in 
kdegames (at least with BSD make) (probably in all modules). I'm working on a 
fix. The exit code for cvs.sh is incorrect in some cases when configure_files 
is called. Patch attached, feel free to substitute "true" for ":" if you 
think that is more portable.

am_edit needs some patching as well. Like I've said before, BSD make is less 
clever about canonicalizing target names than gmake is, so we need some extra 
targets without ".", since dependency names are usually written as "target", 
not "./target". The patch also adds a convenience target "all-mocs" that 
builds all the mocs in a directory. Shouldn't we have a .PHONY target listing 
all our fake targets, anyway?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cvs.sh.patch
Type: text/x-diff
Size: 668 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20020424/39edd14b/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: am_edit.patch
Type: text/x-diff
Size: 6683 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20020424/39edd14b/attachment-0001.patch>