Send File / invokeMailer

[George Staikos]

On April 11, 2002 17:26, Waldo Bastian wrote:
> On Thursday 11 April 2002 01:07 pm, George Staikos wrote:
> > So basically 3.0 is already broken with this feature.  We need to fix it
> > for 3.1.  Two alternative suggestions:
> >
> > 1) Create two invokeMailer commands, one trusted, one untrusted.
> > 2) Audit khtml and friends to make sure that they strip attach=
> > everywhere.
>
> I would go for 2, if there are many places that need it then we could
> consider adding an untrusted invokeMailer command but I don't think that's
> needed.

   Ok this was my feeling too, but I thought I would solicit before 
influencing. :)

> I will add these extra KURL methods that you suggested to make this easier.
> (I'm not going to use QMap so it will not be the most CPU efficient
> implementation but I don't think that is important since starting KMail
> isn't CPU efficient either >:-)

  Great thanks!!

> I would like to suggest the following names to stay consistant with the
> already existing "queryItem()" function:
>
> addQueryItem(name,value);
> removeQueryItem(name);
> modifyQueryItem(name,newvalue);
>
> Implementation similar to KURL::queryItem.

   That looks good to me.

   Eventually we considered adding a static method that would convert a query 
to a QMap and vice versa.  This would give at least a slight performance 
improvement in some applications, and definitely reduce the amount of work 
required in the app.

> I will add those later this week, or you can do it yourself if you like.

   Please go ahead.  I really don't have time for the next three weeks (my 
last final exams, finally!!).

-- 

George Staikos