[PATCH] make KMessageBox::warningContinueCancel do what it says

Martijn Klingens martijn at martijn.homeip.net
Thu Apr 11 13:00:35 BST 2002


On Wed, 10 Apr 2002, George Staikos wrote:
> > warningContinueCancel calls warningContinueCancelList, which in turn
> > creates a KDialogBase with a ButtonCode 'Yes' for the continue button.
> > There is no predefined ButtonCode Cont available, so I wonder what the
> > proper fix is. Should that code be added? Then the fix can go into
> > kdialogbase.cpp, using the continue button properly there, and not as a
> > customized yes button.
>
>   I can agree with this.  Is there any chance you could fix this sometime?
> I'm sorry but I'm just starting exams and I'm very busy.  I won't be able to
> look at this again for a month probably.

Will try. Could you in the mean time apply your patch to the branch with a
comment stating it's a temporary workaround that is (will be) fixed in
HEAD? Adding members to enums in a patch release sounds a bit bad, so the
proper fix can't go into the branch...

>    Well is it possible that someone might want a button with no text?  If not,
> then isEmpty() is better.

Right. isNull() is better indeed.

Martijn






More information about the kde-core-devel mailing list