[PATCH] make KMessageBox::warningContinueCancel do what it says

[George Staikos]

On April 7, 2002 08:46, Martijn Klingens wrote:
> > This patch fixes it for me.
> > Ok to apply and backport?
>
> It only fixes the symptoms and not the cause, though.
>
> warningContinueCancel calls warningContinueCancelList, which in turn
> creates a KDialogBase with a ButtonCode 'Yes' for the continue button.
> There is no predefined ButtonCode Cont available, so I wonder what the
> proper fix is. Should that code be added? Then the fix can go into
> kdialogbase.cpp, using the continue button properly there, and not as a
> customized yes button.

  I can agree with this.  Is there any chance you could fix this sometime?  
I'm sorry but I'm just starting exams and I'm very busy.  I won't be able to 
look at this again for a month probably.

> I don't think this was intentional. Null strings should be handled like the
> default argument I think.

  Good. ;)

> PS: Is there a reason why you did 'buttonContinue.text() == QString::null'
> instead of 'buttonContinue.text().isNull()' ? I always use the latter, so
> if that has side effects I'd rather know about them...
> Actually, thinking of this, you probably don't want to trigger on a null
> string, but on an empty string, so you'd even need isEmpty().

   Well is it possible that someone might want a button with no text?  If not, 
then isEmpty() is better.

-- 

George Staikos