[PATCH] ContactListView width in KAddressBook

Malte Starostik malte at kde.org
Wed Apr 3 13:07:47 BST 2002


Am Wednesday 03 April 2002 13:56 schrieb Scott Wheeler:
> On Wednesday 03 April 2002 04:47 am, Malte Starostik wrote:
> > I don't think it's the correct fix. I also had this problem in kim.
> > Thanks to your mail I now found out why it happened :-)
> > The problem is that the fullWidth property is designable but the
> > setFullWidth() change makes it unusable from designer. Any objections
> > against the attached patch? It won't fix apps linked against old kdelibs
> > though due to the new virtual reimplementation.
>
> Wouldn't that be BIC?  Sorry, I don't know very well what makes things BIC
> very well, but it seems like adding methods at this point would.
It's not BIC, apps linked against kdelibs 3.0 will still run, they will just 
not call the reimplementation. Thus they will suffer from the size problem, 
but I doubt it concerns too many apps. Should the patch make into the branch, 
it'll not hit too many new apps either :-)

> So, this does look like a better way of doing things, but I don't know if
> it can be used now.  If it can't be used, I think we should still apply my
> patch.
Your patch looks good for KAddressBook, I was just looking for a more general 
solution.

-- 
Malte Starostik
PGP: 1024D/D2F3C787 [C138 2121 FAF3 410A 1C2A  27CD 5431 7745 D2F3 C787]





More information about the kde-core-devel mailing list