phab reviews

[Ben Cooksley]

On Sun, Aug 27, 2017 at 1:15 AM, Adriaan de Groot <groot at kde.org> wrote:
> On Saturday 26 August 2017 23:06:29 Ben Cooksley wrote:
>> > Not from `arc` which is a wholly different problem I suppose. But yes,
>> > it's kinda manageable, just not all that convenient. The tricky bit is
>> > really figuring out who to set as reviewer to begin with.
>>
>> Ideally you wouldn't need to set a reviewer at all - it should be
>> handled for you automatically.
>
> Would it make sense to add this information -- possibly just as a comment, but
> it'd be better as real data -- in the .arcconfig of each repo? That would
> require work from Phab upstream to do right, but it would be useful so that
> individual repo's can say
>
> reviewers: [ tom, dick, harry ]
>
> or whatever the right JSON formatting is for that.

That would potentially be another way of doing it yes. However if
someone isn't using Arcanist to make their submission then they won't
be affected by this (they could manually check it I guess though).

>
> [ade]

Cheers,
Ben