[kde-community] What is a GitHub pull request exactly?
staniek at kde.org
Sat Sep 19 21:38:57 UTC 2015
On 19 September 2015 at 23:06, Eike Hein <hein at kde.org> wrote:
> On 09/19/2015 10:32 PM, Kevin Krammer wrote:
>> I don't see there this github review is coming from.
> Review is an interactive process where you ask for changes and
> iterate. Once you open the door to doing it on GitHub, you will:
> * Have a hard time making some contributors understand why
> they should go through the trouble of moving to Phabricator
> in the midst of the review process, or next time.
> * Have a hard time making some KDE developers understand why
> they shouldn't just do it on GitHub.
> I don't understand why you expect thinks like "if it matters
> people will take it to RB/Phab as second stage" or "after the
> first patch we ask someone to get an account and switch to
> Phab" will happen as a matter of course. It's so much more
> likely that people who are comfortable with GitHub will ask
> those who don't to comply (monitor it for requests, respond
> to requests, participate), or they just won't be able to agree.
There are no such people so far, no people that come and say: change
this and that workflow or I'll destroy your project. I'd say many
projects are rather ignored than attacked even in the very close C++
world and that's the worst thing that can happen IMHO. I wouldn't see
another cases like KHTML->WebKit-type of forks for example.
These two things are different:
- asking people to apply for KDE developer account to just use a git
storage for placing a single initial commits on first contact (the
application shall be rejected anyway since they are not contributors
and have no mentor's recommendation... catch-22)
- asking people that decided to contribute further after first
successes (hey, these KDE folks accepted my fixes, nice, I'll learn
the workflow then, it pays off!)
Cases with SoK and GSoC are different because applicants agree to the
rules the first time they apply, they explicitly join KDE even if for
a few days/weeks. Other 3rd-parties are *not yet* sure it makes sense
I have enough of these probabilistic analysis of what most likely
happen. Most of us are largely here for fun. I am not a white collar
in this relation to ask people to confront with a wall of text on the
first contact. Your attitude may differ but please give me the freedom
of forming relations in my way.
I am feeling strong enough to trust people and integrate with the
With any git storages that count in this world.
regards, Jaroslaw Staniek
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
: A graphic art and office suite - http://calligra.org
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
More information about the kde-community