[kde-community] Write our own pull request bot?

Eike Hein hein at kde.org
Sat Sep 19 17:55:08 UTC 2015



On 09/19/2015 07:49 PM, Martin Klapetek wrote:
> We wouldn't get no lock-in though. Not even remotely. It will simply
> be another path for an incoming patch. If the patch in question ends
> up on Phabricator and gets reviewed on Phabricator and merged from
> Phabricator, it is no different than the patch initially arriving by email,
> irc/paste etc. Just a different input route.

That doesn't address Sune's concern though. If you
get a patch by email you can reply by email; the
comm channel stays the same. Ditto IRC. If you file
a pull req on GitHub and it gets imported into Phab
which you don't have an account for yet and can't
interact with using the same client (git, or the
website you were using) you were already using, you
are inserting a hump in that. The requestee wouldn't
even get emails about review comments unless the bot
does complicated steps like trying to use the GitHub
API to read out an account email (if it even can).

Auto-import is a slight improvement over auto-reject
on the "it snubs people" front, but it's not a big
one and it creates a lot of practical concerns. Some
of those could be addressed with more code, if some-
one writes it - but then it should be written and
tested and evluated before we enable that channel.


Cheers,
Eike



More information about the kde-community mailing list