[kde-community] What is a GitHub pull request exactly?

Kevin Krammer krammer at kde.org
Sat Sep 19 16:40:47 UTC 2015


On Saturday, 2015-09-19, 17:47:38, Martin Graesslin wrote:
> On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote:
> > If the problem is somewhere in (a), where is it?
> 
> I'm afraid of code review happening through the pull request instead of our
> infrastructure. To me github pull requests are not just the "here's the
> patch", but also the code review.

But wouldn't that be just additional code review?

Either on top of no code review or on before actual code review for projects 
that require it?

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-community/attachments/20150919/d2148d7a/attachment.sig>


More information about the kde-community mailing list