D16894: [ECM] use a macro to add compiler flags conditionally

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D16894#402364 <https://phabricator.kde.org/D16894#402364>, @rjvbb wrote:
  
  >
  
  
  
  
  > Christophe: can you please be more specific why sphinx fails? Also, is there an existing unittest I can clone and adapt?
  
  There are tests for other ECM modules in the **tests** subdir.

INLINE COMMENTS

> rjvbb wrote in ECMAddCompilerFlag.cmake:1-25
> I'm guessing you meant "Please move [...]" and not that this would somehow happen automagically(?)

Indeed.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190131/2b3dc256/attachment-0001.html>