D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Vlad Zagorodniy]

zzag added a comment.


  In D18167#398076 <https://phabricator.kde.org/D18167#398076>, @graesslin wrote:
  
  > The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers. If devs don't know and now fix the warnings, they can bring in human error.
  
  
  If I understand this paragraph correctly, introduction of unrelated changes, which can break code, is a human error, is it correct?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: zzag, davidedmundson, kossebau, graesslin, apol, vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190122/9a4a93d9/attachment.html>