D13800: Drop outdated QT_USE_FAST_OPERATOR_PLUS

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Some context from Olivier:
  [15:06] <frinring> isn't QT_USE_FAST_CONCATENATION no more a thing since late 4.8, and in qt5 only QT_USE_FAST_OPERATOR_PLUS is still considered?
  [15:12] <frinring> and QT_USE_QSTRINGBUILDER is a superset of QT_USE_FAST_OPERATOR_PLUS, so with the initial the latter is not needed, or?
  [15:13] <frinring> ogoffart: hi. can you confirm that^ ?
  [16:52] <ogoffart> frinring: yes, QT_USE_QSTRINGBUILDER is the new name
  [16:55] <frinring> ogoffart: not just the new name, but also covers qbytearray, right? so QT_USE_FAST_CONCATENATION is defunc in qt5, QT_USE_FAST_OPERATOR_PLUS undocumented but still covering qstring, and QT_USE_QSTRINGBUILDER the documented thing, which covers both qstring & qbytearray
  [16:55] <frinring> so dropping QT_USE_FAST_CONCATENATION from code is dead code clean up, replacing QT_USE_FAST_OPERATOR_PLUS with QT_USE_QSTRINGBUILDER needs some check first, right?
  [16:57] <ogoffart> yes, right
  
  And related old blog post: http://blog.qt.io/blog/2011/06/13/string-concatenation-with-qstringbuilder/

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D13800

To: kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20180629/decda56a/attachment.html>