D13800: Drop outdated QT_USE_FAST_OPERATOR_PLUS

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri Jun 29 18:40:08 UTC 2018


kossebau created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  QT_USE_FAST_OPERATOR_PLUS has been deprecated in Qt 4.8, in favour of
  QT_USE_QSTRINGBUILDER. The latter also covers QByteArray.
  
  Qt5 headers still supports QT_USE_FAST_OPERATOR_PLUS (at least 5.11.1),
  as subset of QT_USE_QSTRINGBUILDER as it was introduced in Qt4.8,
  but not as documented build flag.
  
  Given QT_USE_QSTRINGBUILDER is set here and thus triggers anything that
  QT_USE_FAST_OPERATOR_PLUS would trigger in Qt code, removing it should
  clean up the macro from undocumented features and thus reduce confusion.
  
  No non-Qt is known at least in KDE repos which checks this build flag
  otherwise, so no regression should be expected here as well.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  dropQT_USE_FAST_OPERATOR_PLUS

REVISION DETAIL
  https://phabricator.kde.org/D13800

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20180629/dce4c2b8/attachment-0001.html>


More information about the Kde-buildsystem mailing list