D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

Albert Astals Cid noreply at phabricator.kde.org
Wed Jun 27 21:09:56 UTC 2018


aacid added inline comments.

INLINE COMMENTS

> apol wrote in KDEFrameworkCompilerSettings.cmake:70
> Maybe you can add `-Wzero-as-null-pointer-constant` to the if above which is `gcc or clang`?

problem it's i also need the version check and since we already have it here it doesn't make the code any more simpler.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  arcpatch-D10166 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10166

To: aacid, cgiboudeaux
Cc: apol, kde-frameworks-devel, kde-buildsystem, cgiboudeaux, dhaumann, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20180627/2b20027c/attachment.html>


More information about the Kde-buildsystem mailing list