D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

[Aleix Pol Gonzalez]

apol added a comment.




INLINE COMMENTS

> KDEFrameworkCompilerSettings.cmake:70
>     if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS "5.0.0")
> -      set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override" )
> +      set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override -Wlogical-op -Wzero-as-null-pointer-constant" )
> +   endif()

Maybe you can add `-Wzero-as-null-pointer-constant` to the if above which is `gcc or clang`?

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  arcpatch-D10166 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10166

To: aacid, cgiboudeaux
Cc: apol, kde-frameworks-devel, kde-buildsystem, cgiboudeaux, dhaumann, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20180627/6278f1c0/attachment.html>