D17547: Bring FindFontconfig.cmake up to ECM standards

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindFontconfig.cmake:58
> +set(Fontconfig_DEFINITIONS ${PC_FONTCONFIG_CFLAGS_OTHER})
> +set(Fontconfig_VERSION ${PC_FONTCONFIG_VERSION})
>  

You need a fallback method for platforms where pkgconfig isn't usable.

fontconfig.h defines FC_MAJOR, FC_MINOR, FC_REVISION

> FindFontconfig.cmake:72
> +include(FindPackageHandleStandardArgs)
> +find_package_handle_standard_args(Fontconfig DEFAULT_MSG Fontconfig_LIBRARIES Fontconfig_INCLUDE_DIRS)
>  

Now that you have Fontconfig_VERSION, please use the second form:

  find_package_handle_standard_args(Fontconfig
  FOUND_VAR Fontconfig_FOUND
  REQUIRED_VARS Fontconfig_LIBRARIES Fontconfig_INCLUDE_DIRS
  VERSION_VAR Fontconfig_VERSION)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17547

To: vkrause, #build_system
Cc: cgiboudeaux, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20181215/d7a5fe69/attachment.html>