<table><tr><td style="">cgiboudeaux added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17547">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17547#inline-96560">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindFontconfig.cmake:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">    </span><span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">F<span class="bright">ONTCONFIG</span>_DEFINITIONS</span> <span style="color: #aa2211">${</span><span style="color: #001294">PC_FONTCONFIG_CFLAGS_OTHER</span><span style="color: #aa2211">}</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">  </span><span style="color: #304a96"><span class="bright">endif</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">NOT</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">WIN32</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">F<span class="bright">ontconfig</span>_DEFINITIONS</span> <span style="color: #aa2211">${</span><span style="color: #001294">PC_FONTCONFIG_CFLAGS_OTHER</span><span style="color: #aa2211">}</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #304a96"><span class="bright">set</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">Fontconfig_VERSION</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">PC_FONTCONFIG_VERSION</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You need a fallback method for platforms where pkgconfig isn't usable.</p>

<p style="padding: 0; margin: 8px;">fontconfig.h defines FC_MAJOR, FC_MINOR, FC_REVISION</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17547#inline-96561">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindFontconfig.cmake:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">include</span><span class="p">(</span><span style="color: #766510">FindPackageHandleStandardArgs</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">  </span><span style="color: #304a96"><span class="bright">find_package_handle_standard_args</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">Fontconfig</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">DEFAULT_MSG</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">FONTCONFIG_LIBRARIES</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">FONTCONFIG_INCLUDE_DIR</span></span><span class="bright"> </span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #304a96"><span class="bright">find_package_handle_standard_args</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">Fontconfig</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">DEFAULT_MSG</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">Fontconfig_LIBRARIES</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">Fontconfig_INCLUDE_DIRS</span></span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Now that you have Fontconfig_VERSION, please use the second form:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">find_package_handle_standard_args(Fontconfig
FOUND_VAR Fontconfig_FOUND
REQUIRED_VARS Fontconfig_LIBRARIES Fontconfig_INCLUDE_DIRS
VERSION_VAR Fontconfig_VERSION)</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17547">https://phabricator.kde.org/D17547</a></div></div><br /><div><strong>To: </strong>vkrause, Build System<br /><strong>Cc: </strong>cgiboudeaux, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>